Feedback addressed. Landing.
https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime-debug.cc#newcode19
src/runtime/runtime-debug.cc:19: RUNTIME_FUNCTION(Runtime_DebugBreak) {
On 2015/07/23 at 11:36:15, Michael Starzinger wrote:
nit: Can we add the following boilerplate to the top of the function?
SealHandleScope shs(isolate);
DCHECK(args.length() == 0);
Done.
https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime.h
File src/runtime/runtime.h (right):
https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime.h#newcode729
src/runtime/runtime.h:729: #define FOR_EACH_INTRINSIC_IC(F)
\
On 2015/07/23 at 11:36:15, Michael Starzinger wrote:
nit: Can we add a short one-line comment saying that those runtime
function are actually implemented in "ic.cc" file outside of the
"runtime" directory?
Done
https://codereview.chromium.org/1248303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
