LGTM
http://codereview.chromium.org/574009/diff/1/2 File src/ia32/assembler-ia32.cc (right): http://codereview.chromium.org/574009/diff/1/2#newcode349 src/ia32/assembler-ia32.cc:349: ASSERT(pc_ <= reloc_info_writer.pos()); // no overlap Missed one! http://codereview.chromium.org/574009/diff/1/2#newcode767 src/ia32/assembler-ia32.cc:767: if (src.is(eax) || dst.is(eax)) { // Single-byte encoding And here. http://codereview.chromium.org/574009/diff/1/5 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/574009/diff/1/5#newcode342 src/x64/assembler-x64.cc:342: ASSERT(pc_ <= reloc_info_writer.pos()); // no overlap And here. http://codereview.chromium.org/574009/diff/1/5#newcode392 src/x64/assembler-x64.cc:392: ASSERT(buffer_overflow()); // should not call this otherwise Superfluous comment is wrongly formatted. http://codereview.chromium.org/574009/diff/1/5#newcode421 src/x64/assembler-x64.cc:421: //Ccopy the data. Oops. http://codereview.chromium.org/574009 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
