http://codereview.chromium.org/571005/diff/1/2 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/571005/diff/1/2#newcode7271 src/arm/codegen-arm.cc:7271: ASSERT_EQ(0, kSmiTag); Done. And JumpIfEitherSmi, which is what we need here. http://codereview.chromium.org/571005/diff/1/2#newcode7403 src/arm/codegen-arm.cc:7403: __ add(r6, r7, Operand(SeqAsciiString::kHeaderSize - kHeapObjectTag)); Doesn't work in ARM. Operand and MemOperand are distinct, and we only have FieldMemOperand, not FieldOperand (and I don't think we should). http://codereview.chromium.org/571005/diff/1/3 File src/arm/codegen-arm.h (right): http://codereview.chromium.org/571005/diff/1/3#newcode572 src/arm/codegen-arm.h:572: class StringAddStub: public StringStubBase { I don't think so (but could be convinced). The fact that the three implementations are identical doesn't necessarily mean that they have to be so. Different platforms can have different requirements and parameterizations. In fact, we currently don't create both kinds of stubs on ARM (which is a mistake that I'll fix and upload a new version). If the versions are not inherently identical, I don't want to collapse them. It will make it harder to change one of them later. http://codereview.chromium.org/571005 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
