Reviewers: Evan Martin, Mads Ager,
Message:
This seems to still build on both Windows and Linux.
I did not find a way to make the gyp generation match the flags we use in
the
"official" SCons build for V8. However removing the inheritance of Chromium
flags seems only to affects warning flags.
There where several issues with matching the flags. First of all the
-Werror and
-Wall seemed to always be removed by build/external_code.gypi. Another
issue is
that we use -pedantic for our C++ files, but there is one C file in the
repository dtoa-config.c which should not have -pedantic. Also for this C
file
the -Wall and -Werror is not suppressed.
So I gave up on matching the flags.
When compiling the x64 version on Linux the following flags from the SCons
build
is not present
-Wall
-Werror
-W
-Wno-unused-parameter
-Wnon-virtual-dtor xx
-pedantic XX
-ansi
Whereas the following additional flags are passed:
-pthread
-D_FILE_OFFSET_BITS=64
-fno-strict-aliasing
-fno-ident
-fno-asynchronous-unwind-tables
-fno-threadsafe-statics
-fvisibility-inlines-hidden
-DCHROMIUM_BUILD
-DENABLE_GPU=1
-DNDEBUG
-DNVALGRIND
On Windows we will get the following additional defines
_CRT_SECURE_NO_DEPRECATE',
_CRT_NONSTDC_NO_WARNINGS',
_CRT_NONSTDC_NO_DEPRECATE',
_SCL_SECURE_NO_DEPRECATE',
And warning 4800 disabled and warnings not treated as errors.
Description:
Remove inheritance of chromium flags
Please review this at http://codereview.chromium.org/570022
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M tools/gyp/v8.gyp
Index: tools/gyp/v8.gyp
===================================================================
--- tools/gyp/v8.gyp (revision 3803)
+++ tools/gyp/v8.gyp (working copy)
@@ -27,7 +27,6 @@
{
'variables': {
- 'chromium_code': 1,
'msvs_use_common_release': 0,
'gcc_version%': 'unknown',
'target_arch%': 'ia32',
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
