Reviewers: oth, Hannes Payer,
Message:
Orion: could you take a look please?
Hannes: could you stamp for OWNER/committer (any comments welcome too).
Description:
[interpreter]: Fix interpreter handler table initialization.
BUG=v8:4280
LOG=N
Please review this at https://codereview.chromium.org/1288893003/
Base URL:
https://chromium.googlesource.com/v8/v8.git@interpreter_bytecode_regs
Affected files (+1, -5 lines):
M src/interpreter/interpreter.cc
Index: src/interpreter/interpreter.cc
diff --git a/src/interpreter/interpreter.cc b/src/interpreter/interpreter.cc
index
50abb0f1a290053782082ad52f0cce149d0876bb..4f961318085e12bbf63f5d336d006ddda14c909d
100644
--- a/src/interpreter/interpreter.cc
+++ b/src/interpreter/interpreter.cc
@@ -31,9 +31,6 @@ Handle<FixedArray>
Interpreter::CreateUninitializedInterpreterTable(
// it was allocated on the first page (which is always immovable).
DCHECK(isolate->heap()->old_space()->FirstPage()->Contains(
handler_table->address()));
- for (int i = 0; i < static_cast<int>(Bytecode::kLast); i++) {
- handler_table->set(i,
isolate->builtins()->builtin(Builtins::kIllegal));
- }
return handler_table;
}
@@ -62,8 +59,7 @@ void Interpreter::Initialize() {
bool Interpreter::IsInterpreterTableInitialized(
Handle<FixedArray> handler_table) {
DCHECK(handler_table->length() == static_cast<int>(Bytecode::kLast) + 1);
- return handler_table->get(0) ==
- isolate_->builtins()->builtin(Builtins::kIllegal);
+ return handler_table->get(0) != isolate_->heap()->undefined_value();
}
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
