Thanks for the review. Comments addressed, PTAL.
https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interpreter-assembler.h
File src/compiler/interpreter-assembler.h (right):
https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interpreter-assembler.h#newcode40
src/compiler/interpreter-assembler.h:40: Node* IncomingAccumulator();
On 2015/08/14 12:42:20, titzer wrote:
The distinction between "incoming" accumulator and the "outgoing"
accumulator is
somewhat confusing. E.g. it really only makes sense from the
perspective of the
user of the assembler. Maybe just "GetAccumulator() and
SetAccumulator()", since
the assembler is just holding the current state?
Good idea. Done.
https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interpreter-assembler.h#newcode71
src/compiler/interpreter-assembler.h:71: Node* RegisterFilePointer();
On 2015/08/14 12:42:20, titzer wrote:
Can we name this RegisterFileRawPointer() and the one below
BytecodeArrayTaggedPointer() to keep them straight?
Done (also done for DispatchTablePointer below)
https://codereview.chromium.org/1289863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
