Reviewers: Hannes Payer,
Message:
Hannes: could you please take a look, thanks.
Description:
[Interpreter] Move interpreter initialization until after snapshot
deserialization.
The interpreter needs to be initialized after the snapshot has been
deserialized.
BUG=v8:4280
LOG=N
Please review this at https://codereview.chromium.org/1290883004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -4 lines):
M src/isolate.cc
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index
47ab368dcc6acd3c30571d683e4d7fa606e5cfdc..980c95d58aa4dafe183d3ab436cb45d2b694b4e6
100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2167,10 +2167,6 @@ bool Isolate::Init(Deserializer* des) {
bootstrapper_->Initialize(create_heap_objects);
builtins_.SetUp(this, create_heap_objects);
- if (FLAG_ignition) {
- interpreter_->Initialize();
- }
-
if (FLAG_log_internal_timer_events) {
set_event_logger(Logger::DefaultEventLoggerSentinel);
}
@@ -2197,6 +2193,10 @@ bool Isolate::Init(Deserializer* des) {
}
stub_cache_->Initialize();
+ if (FLAG_ignition) {
+ interpreter_->Initialize();
+ }
+
// Finish initialization of ThreadLocal after deserialization is done.
clear_pending_exception();
clear_pending_message();
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
