https://codereview.chromium.org/1295883002/diff/60001/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/1295883002/diff/60001/src/scanner.h#newcode547
src/scanner.h:547: (current_.literal_chars == &literal_buffers_[0])
On 2015/08/17 at 18:24:39, adamk wrote:
On 2015/08/15 00:28:31, adamk wrote:
> Why switch to using an array for this? The advantage of separate
names is that a
> typo is a compile-time error, instead of an OOB access at runtime.
I'd prefer to
> go back unless there's a particular need for using an array.
I didn't see this addressed in the latest patch.
Oops, fixed.
https://codereview.chromium.org/1295883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
