lgtm with a couple of nits.
https://codereview.chromium.org/1294543002/diff/30001/test/cctest/interpreter/test-bytecode-generator.cc
File test/cctest/interpreter/test-bytecode-generator.cc (right):
https://codereview.chromium.org/1294543002/diff/30001/test/cctest/interpreter/test-bytecode-generator.cc#newcode23
test/cctest/interpreter/test-bytecode-generator.cc:23:
i::FLAG_print_bytecode = false;
nit - remove the "i::FLAG_print_bytecode = false"? It should be false by
default and if you don't force it to false then you can pass
"--print_bytecode" to the tests if you want to see the bytecode for a
particular test.
https://codereview.chromium.org/1294543002/diff/30001/test/cctest/interpreter/test-bytecode-generator.cc#newcode53
test/cctest/interpreter/test-bytecode-generator.cc:53:
nit - extra newline
https://codereview.chromium.org/1294543002/diff/30001/test/cctest/interpreter/test-bytecode-generator.cc#newcode112
test/cctest/interpreter/test-bytecode-generator.cc:112: }}};
indentation seems a little unusual here - is "git cl format"
responsable?
https://codereview.chromium.org/1294543002/diff/30001/test/cctest/interpreter/test-bytecode-generator.cc#newcode123
test/cctest/interpreter/test-bytecode-generator.cc:123: }
nit - extra newline below
https://codereview.chromium.org/1294543002/diff/30001/test/cctest/interpreter/test-bytecode-generator.cc#newcode124
test/cctest/interpreter/test-bytecode-generator.cc:124: }
nit - comments on closing namespace brackets.
https://codereview.chromium.org/1294543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
