https://codereview.chromium.org/1287173004/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/1287173004/diff/1/src/arm/assembler-arm.cc#newcode129
src/arm/assembler-arm.cc:129: cpu.variant() == base::CPU::NVIDIA_DENVER
&&
same as arm64
https://codereview.chromium.org/1287173004/diff/1/src/arm64/assembler-arm64.cc
File src/arm64/assembler-arm64.cc (right):
https://codereview.chromium.org/1287173004/diff/1/src/arm64/assembler-arm64.cc#newcode55
src/arm64/assembler-arm64.cc:55: cpu.variant() ==
base::CPU::NVIDIA_DENVER &&
Denver is a CPU part (like A57, A53 for ARM), so it looks like the
checks are switched: part should be Denver and variant should be less
than 0, 1 or 2. no? The initial code was wrong then.
https://codereview.chromium.org/1287173004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
