On 2015/08/19 13:41:13, Michael Lippautz wrote:
heap lgtm

https://codereview.chromium.org/1293493004/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1293493004/diff/1/src/heap/heap.h#newcode297
src/heap/heap.h:297: #define PRIVATE_SYMBOL_LIST(V)              \
I wonder whether it would (at some point) make sense to move this somewhere else? We create strong roots for those symbols but that's all the heap cares
about ;)

Not sure. We also have a list of strings right above.

https://codereview.chromium.org/1293493004/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to