Reviewers: Benedikt Meurer,
Description:
Turn v8.h into a normal header.
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/1293593005/
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-fdlibm
Affected files (+7, -18 lines):
M src/DEPS
D src/compiler/DEPS
M src/interpreter/DEPS
M src/v8.h
Index: src/compiler/DEPS
diff --git a/src/compiler/DEPS b/src/compiler/DEPS
deleted file mode 100644
index
60e2f6d742e35e8516fa7faa8bad1c28a92622db..0000000000000000000000000000000000000000
--- a/src/compiler/DEPS
+++ /dev/null
@@ -1,3 +0,0 @@
-include_rules = [
- "-src/v8.h",
-]
Index: src/DEPS
diff --git a/src/DEPS b/src/DEPS
index
4b95456a17d618b02394ddc740d23e4af4a60ad0..7350f61f9f2b755481502b2e201e535055da25e2
100644
--- a/src/DEPS
+++ b/src/DEPS
@@ -14,9 +14,10 @@ include_rules = [
specific_include_rules = {
".*\.h": [
- # Note that src/v8.h is the top header for some .cc files, it
shouldn't be
- # included in any .h files though. In the long run we should make
src/v8.h
- # act like any normal header file, instead of a grab-bag include.
+ # Note that src/v8.h by now is a regular header file, it doesn't
provide
+ # any special declarations besides the V8 class. There should be no
need
+ # for including it in any .h files though. This rule is just a
reminder,
+ # and can be removed once the dust has settled.
"-src/v8.h",
],
"d8\.cc": [
Index: src/interpreter/DEPS
diff --git a/src/interpreter/DEPS b/src/interpreter/DEPS
index
f6fc3f63d7e1682f1f756ab1a3309483b3bc05dd..f8d6b98fd82577e8910655bd8da004285bf4358d
100644
--- a/src/interpreter/DEPS
+++ b/src/interpreter/DEPS
@@ -1,4 +1,3 @@
include_rules = [
"+src/compiler/interpreter-assembler.h",
- "-src/v8.h",
]
Index: src/v8.h
diff --git a/src/v8.h b/src/v8.h
index
23e1a1230c893ce51d681590393b9a62dcef3c76..da5fe46154c5734836eb5f18b8bb7317a64c5aa3
100644
--- a/src/v8.h
+++ b/src/v8.h
@@ -2,13 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-//
-// Top include for all V8 .cc files.
-//
-
#ifndef V8_V8_H_
#define V8_V8_H_
+#include "include/v8.h"
+#include "src/allocation.h"
+
#if defined(GOOGLE3) || defined(DCHECK_ALWAYS_ON)
// Google3 and Chromium special flag handling.
#if defined(DEBUG) && defined(NDEBUG)
@@ -25,13 +24,6 @@
#error both DEBUG and NDEBUG are set
#endif
-// Basic includes
-#include "include/v8.h"
-#include "src/allocation.h"
-
-// Objects
-#include "src/objects-inl.h"
-
namespace v8 {
namespace internal {
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
