LGTM on compiler, full-codegen, objects and contexts. Didn't look at the
rest.
https://codereview.chromium.org/1292753007/diff/1/src/contexts.cc
File src/contexts.cc (right):
https://codereview.chromium.org/1292753007/diff/1/src/contexts.cc#newcode65
src/contexts.cc:65: return ext->IsSloppyBlockWithEvalContextExtension()
nit: As discussed offline, it is not immediately clear from the code
that a block-context containing the new pair will always be a
declaration scope (i.e. that pair->scope_info()->is_declaration_scope()
will always hold). Can we leave a comment or DCHECK in that regard here?
https://codereview.chromium.org/1292753007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
