LGTM, just a naming suggestion.
https://codereview.chromium.org/1307963002/diff/1/src/contexts.h
File src/contexts.h (right):
https://codereview.chromium.org/1307963002/diff/1/src/contexts.h#newcode76
src/contexts.h:76: #define IMPORTED_NATIVES(V)
\
nit: What would you think about
s/IMPORTED_NATIVES/NATIVE_CONTEXT_IMPORTED/ here? Or alternatively
"NATIVE_CONTEXT_IMPORTED_FIELDS" even.
https://codereview.chromium.org/1307963002/diff/1/src/contexts.h#newcode132
src/contexts.h:132: #define IMPORTED_PROXY_NATIVES(V)
\
nit: What would you think about
s/IMPORTED_PROXY_NATIVES/NATIVE_CONTEXT_PROXY_IMPORTED/ here?
https://codereview.chromium.org/1307963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
