https://codereview.chromium.org/1303033003/diff/20001/test/mjsunit/regress/regress-520029.js
File test/mjsunit/regress/regress-520029.js (right):
https://codereview.chromium.org/1303033003/diff/20001/test/mjsunit/regress/regress-520029.js#newcode28
test/mjsunit/regress/regress-520029.js:28: try {
On 2015/08/21 at 21:39:04, adamk wrote:
Is this try/catch doing anything?
Yes, it's defining a function __f_14() which references a lexically
scoped local variable. I had thought that this was enough to trigger
https://code.google.com/p/chromium/issues/detail?id=520891 , but
apparently not. I dedup'd that bug and deleted this "test".
https://codereview.chromium.org/1303033003/diff/20001/test/mjsunit/regress/regress-520029.js#newcode34
test/mjsunit/regress/regress-520029.js:34: function __f_21() { }
On 2015/08/21 at 21:39:04, adamk wrote:
Is this function doing anything?
Not sure, it does something to the scopes but I actually can't repro the
original issue (see below).
https://codereview.chromium.org/1303033003/diff/20001/test/mjsunit/regress/regress-520029.js#newcode45
test/mjsunit/regress/regress-520029.js:45: }, ReferenceError);
On 2015/08/21 at 21:39:04, adamk wrote:
Sorry, I'm missing something; why does this cause a reference error?
You're right, this doesn't actually make sense. Another case of me
misdiagnosing a dup bug, and quickly concluding that I fixed it just
because it didn't crash the parser with this patch (it didn't before
either). Removed this from the test.
https://codereview.chromium.org/1303033003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
