On 2015/08/24 14:18:15, rossberg wrote:
https://codereview.chromium.org/1287063004/diff/60001/src/parser.cc File src/parser.cc (right):
https://codereview.chromium.org/1287063004/diff/60001/src/parser.cc#newcode3916
src/parser.cc:3916: parser_->Check(Token::ASSIGN)) {
On 2015/08/24 14:10:10, wingo wrote:
> How on earth does this work? This function is called after the arrow
function
> arguments have been parsed, and its purpose is to transform the
already-parsed
> expression into parameters. I can't see how this can possibly do the right> thing.
You are right, it doesn't make sense. 8} Not sure what I was thinking.
Any idea why this is never hit by the tests?
:) I would guess this is never hit becauseParseArrowFunctionFormalParameterList is only called with Token::ARROW is the
next token in the stream. As to how it works... I guess is_simple is set to false earlier because the expression is not a variableproxy, and the RHS is validated as an expression already by the parser. https://codereview.chromium.org/1287063004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
