https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326
src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() {
On 2015/08/24 16:55:47, Michael Starzinger wrote:
On 2015/08/24 16:36:36, Michael Lippautz wrote:
> Any reason this debug method using prints is inlined?
Nah, can't think of any. Probably just to have is "close" to
Heap::UpdateAllocationsHash above. Moving to the heap.cc files looks
fine to me.
Done.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326
src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() {
On 2015/08/24 16:43:53, Hannes Payer wrote:
On 2015/08/24 16:36:36, Michael Lippautz wrote:
> Any reason this debug method using prints is inlined?
Be gone.
Done.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1090
src/heap/heap.h:1090: inline bool ShouldBePromoted(Address old_address,
int object_size);
On 2015/08/24 16:43:53, Hannes Payer wrote:
Also a private.
Can't as {ScavengingVisitor} (which is not a friend) is using it.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1102
src/heap/heap.h:1102: inline bool OldGenerationAllocationLimitReached();
On 2015/08/24 16:43:53, Hannes Payer wrote:
This one should also be next to the other growing strategy functions.
Done.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1108
src/heap/heap.h:1108: bool RecentIdleNotificationHappened();
On 2015/08/24 16:43:53, Hannes Payer wrote:
Private. There should be a section for them.
Done.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1707
src/heap/heap.h:1707: void GarbageCollectionEpilogue();
On 2015/08/24 16:55:47, Michael Starzinger wrote:
Can both go into the "Actual GC" section as well, probably near the
top of that
section, as it is common to scavenge and full GC.
Done.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1766
src/heap/heap.h:1766: void Scavenge();
On 2015/08/24 16:55:47, Michael Starzinger wrote:
Can go into the "Actual GC" section, right before DoScavenge.
Done.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1778
src/heap/heap.h:1778: void ProcessAllocationSites(WeakObjectRetainer*
retainer);
On 2015/08/24 16:55:47, Michael Starzinger wrote:
Can both go into the "Actual GC" section after
ProcessAllWeakReferences and
ProcessYoungWeakReferences.
Done.
https://codereview.chromium.org/1313513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
