Fixed nits. See comment below about spread treatment.
https://codereview.chromium.org/1315823002/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1315823002/diff/20001/src/preparser.h#newcode2279
src/preparser.h:2279: } else if (allow_harmony_rest_parameters() &&
Check(Token::ELLIPSIS)) {
On 2015/08/25 12:55:56, rossberg wrote:
I wonder, does rest actually need special treatment here? Can't it
simply be
parsed as spread in the else case below, and later be rewritten?
I think it does need special treatment. All the other places that parse
spread (array literals, call arguments, comma expressions) parse spread
specially. We could of course parse it anywhere as a prefix unary op,
marking the production invalid as an expression, but that is a riskier
change if we are considering uplifting this to M46. WDYT?
https://codereview.chromium.org/1315823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.