lgtm
https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h#newcode1349
src/heap/heap.h:1349: inline void AddExternalString(String* string);
On 2015/08/25 14:18:30, Michael Starzinger wrote:
Wasn't sure whether "AddExternalString" or "RegisterExternalString"
would be a
better name for this. WDYT? Happy to change it.
We already have a couple of Register*() methods. Let's rename it.
https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h#newcode1596
src/heap/heap.h:1596: friend class Heap;
Move to bottom.
https://codereview.chromium.org/1312553003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
