Reviewers: Michael Starzinger,
Message:
Michi, could you take a look please? Thanks.
https://codereview.chromium.org/1321663003/diff/40001/test/cctest/interpreter/test-bytecode-generator.cc
File test/cctest/interpreter/test-bytecode-generator.cc (right):
https://codereview.chromium.org/1321663003/diff/40001/test/cctest/interpreter/test-bytecode-generator.cc#newcode257
test/cctest/interpreter/test-bytecode-generator.cc:257: { 3.14, 3.14 }
Michi - looks like double literals aren't de-duped by the parser (we get
a new HeapNumber each time). Is this done elsewhere or have we always
had a new HeapNumber for each double literal?
Description:
[Interpreter] Add support for loading literals from the constant pool.
Adds support to the interpreter for loading literals from the constant pool.
Adds the LoadConstant bytecode and makes use of it for loading large Smis
and
HeapObject literals.
Also removes unused HandleVector from utils.h.
BUG=v8:4280
LOG=N
Please review this at https://codereview.chromium.org/1321663003/
Base URL: https://chromium.googlesource.com/v8/v8.git@int_const_pool_1
Affected files (+407, -75 lines):
M src/DEPS
M src/compiler/interpreter-assembler.h
M src/compiler/interpreter-assembler.cc
M src/heap/identity-map.h
M src/interpreter/bytecode-array-builder.h
M src/interpreter/bytecode-array-builder.cc
M src/interpreter/bytecode-generator.cc
M src/interpreter/bytecodes.h
M src/interpreter/bytecodes.cc
M src/interpreter/interpreter.cc
M src/utils.h
M test/cctest/interpreter/test-bytecode-generator.cc
M test/cctest/interpreter/test-interpreter.cc
M test/unittests/compiler/interpreter-assembler-unittest.cc
M test/unittests/interpreter/bytecode-array-builder-unittest.cc
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
