Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [Interpreter] Add support for parameter variables.
port 5d975694e4d3ecf66716cc5395d4d10c9730f9dd (r30403)
original commit message:
Adds support for parameters to the BytecodeArrayBuilder and
BytecodeGenerator.
Parameters are accessed as negative interpreter registers.
R=weiliang....@intel.com
BUG=
Please review this at https://codereview.chromium.org/1324453003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+8, -3 lines):
M src/x87/builtins-x87.cc
Index: src/x87/builtins-x87.cc
diff --git a/src/x87/builtins-x87.cc b/src/x87/builtins-x87.cc
index
a8aa7e11812784ff78c442b4176843edb789a2cf..cd7568c75c5645c6be44ebb6c98c52be38d57aa0
100644
--- a/src/x87/builtins-x87.cc
+++ b/src/x87/builtins-x87.cc
@@ -752,9 +752,14 @@ void
Builtins::Generate_InterpreterExitTrampoline(MacroAssembler* masm) {
// Leave the frame (also dropping the register file).
__ leave();
- // Return droping receiver + arguments.
- // TODO(rmcilroy): Get number of arguments from BytecodeArray.
- __ Ret(1 * kPointerSize, ecx);
+
+ // Drop receiver + arguments and return.
+ __ mov(ebx, FieldOperand(kInterpreterBytecodeArrayRegister,
+ BytecodeArray::kParameterSizeOffset));
+ __ pop(ecx);
+ __ add(esp, ebx);
+ __ push(ecx);
+ __ ret(0);
}
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
