lgtm with comments.
The next step would be moving the logic out of Heap into an
ArrayBufferTracker
that lives in heap/ and finally add some tests. It would probably have to
be a
cctest that checks the transitions from one map into another.
https://codereview.chromium.org/1316873004/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1316873004/diff/40001/src/heap/heap.cc#newcode1805
src/heap/heap.cc:1805: if (freed_memory) {
Let's make this explcit, i.e., freed_memory > 0
https://codereview.chromium.org/1316873004/diff/40001/src/heap/heap.cc#newcode1828
src/heap/heap.cc:1828: if (freed_memory) {
Ditto here.
https://codereview.chromium.org/1316873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
