https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc#newcode59
src/typing-asm.cc:59: #define RECURSE_EXPR(expr, expected_type, msg)
\
Can these four macros be made into helper functions? AFAICT the only
early return is from RETURN() but that doesn't seem necessary.
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc#newcode143
src/typing-asm.cc:143: if (decl != NULL) SetType(decl->proxy()->var(),
Type::Any(zone()));
Shouldn't globals start at type none?
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc#newcode664
src/typing-asm.cc:664: if (computed_type_->IsArray()) {
Can we factor this to a helper function for array (heap) accesses?
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc#newcode869
src/typing-asm.cc:869: expr->op() == Token::MUL ? Type::Any() :
Type::Number();
I don't understand why MUL takes Type::Any, despite the comment.
Shouldn't it always be Number?
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc#newcode889
src/typing-asm.cc:889: if (intish_ > (1 << 20)) {
kMaxIntishness (or better name)
https://codereview.chromium.org/1322773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
