https://codereview.chromium.org/1325483002/diff/20001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/1325483002/diff/20001/src/builtins.cc#newcode393
src/builtins.cc:393: if (result->IsTheHole()) {
I think hole handling should be in elements.cc and it's only necessary
for holy arrays (see usages of IsHoleyElementsKind(kind()) ).
https://codereview.chromium.org/1325483002/diff/20001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1325483002/diff/20001/src/elements.cc#newcode647
src/elements.cc:647: static Handle<Object> PopImpl(Handle<JSArray>
receiver,
I think FastElementsAccessor is a better place for this implementation.
And ElementsAccessorBase::PopImpl should be unreachable.
https://codereview.chromium.org/1325483002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
