lgtm other than existential questions
https://codereview.chromium.org/1318823010/diff/20001/src/ast-expression-visitor.h
File src/ast-expression-visitor.h (right):
https://codereview.chromium.org/1318823010/diff/20001/src/ast-expression-visitor.h#newcode25
src/ast-expression-visitor.h:25: FunctionLiteral* root);
I think you can drop the "explicit" for multiple argument constructors.
https://codereview.chromium.org/1318823010/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/1318823010/diff/20001/src/hydrogen.cc#newcode8340
src/hydrogen.cc:8340: .Run();
Why does the AstTyper need the osr_ast_id()?
https://codereview.chromium.org/1318823010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
