[v8-dev] VectorICs: Cleanup, remove unnecessary arguments from HandleArrayCases() (issue 1314503003 by mvstanton@chromium.org)

Wed, 02 Sep 2015 05:01:35 -0700 

Reviewers: Igor Sheludko,

Message:
Hi Igor,
A small cleanup CL to remove unnecessary arguments. PTAL, thanks!
--Michael

Description:
VectorICs: Cleanup, remove unnecessary arguments from HandleArrayCases()

BUG=

Please review this at https://codereview.chromium.org/1314503003/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+38, -56 lines):
  M src/arm/code-stubs-arm.cc
  M src/arm64/code-stubs-arm64.cc
  M src/mips/code-stubs-mips.cc
  M src/mips64/code-stubs-mips64.cc
  M src/x64/code-stubs-x64.cc


Index: src/arm/code-stubs-arm.cc
diff --git a/src/arm/code-stubs-arm.cc b/src/arm/code-stubs-arm.cc
index f2828870997759f776d76b73cafb93af3e25804a..0336414fb26c5a4e4a7209a419bc78a3af480c54 100644 
--- a/src/arm/code-stubs-arm.cc
+++ b/src/arm/code-stubs-arm.cc
@@ -4341,11 +4341,10 @@ void LoadICStub::GenerateForTrampoline(MacroAssembler* masm) { 
 }


-static void HandleArrayCases(MacroAssembler* masm, Register receiver,
-                             Register key, Register vector, Register slot,
-                             Register feedback, Register receiver_map,
-                             Register scratch1, Register scratch2,
-                             bool is_polymorphic, Label* miss) {
+static void HandleArrayCases(MacroAssembler* masm, Register feedback,
+                             Register receiver_map, Register scratch1,
+                             Register scratch2, bool is_polymorphic,
+                             Label* miss) {
   // feedback initially contains the feedback array
   Label next_loop, prepare_next;
   Label start_polymorphic;
@@ -4455,8 +4454,7 @@ void LoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   __ ldr(scratch1, FieldMemOperand(feedback, HeapObject::kMapOffset));
   __ CompareRoot(scratch1, Heap::kFixedArrayMapRootIndex);
   __ b(ne, &not_array);
- HandleArrayCases(masm, receiver, name, vector, slot, feedback, receiver_map, 
-                   scratch1, r9, true, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, r9, true, &miss); 

   __ bind(&not_array);
   __ CompareRoot(feedback, Heap::kmegamorphic_symbolRootIndex);
@@ -4516,8 +4514,7 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   // We have a polymorphic element handler.
   Label polymorphic, try_poly_name;
   __ bind(&polymorphic);
- HandleArrayCases(masm, receiver, key, vector, slot, feedback, receiver_map, 
-                   scratch1, r9, true, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, r9, true, &miss); 

   __ bind(&not_array);
   // Is it generic?
@@ -4536,8 +4533,7 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   __ add(feedback, vector, Operand::PointerOffsetFromSmiKey(slot));
   __ ldr(feedback,
FieldMemOperand(feedback, FixedArray::kHeaderSize + kPointerSize)); - HandleArrayCases(masm, receiver, key, vector, slot, feedback, receiver_map, 
-                   scratch1, r9, false, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, r9, false, &miss); 

   __ bind(&miss);
   KeyedLoadIC::GenerateMiss(masm);
Index: src/arm64/code-stubs-arm64.cc
diff --git a/src/arm64/code-stubs-arm64.cc b/src/arm64/code-stubs-arm64.cc
index 62d68fdb8f9b35042a03c8db03a40469ea771ac3..2dbdea230e1a9acbeb47850ac62dea8f5e196a15 100644 
--- a/src/arm64/code-stubs-arm64.cc
+++ b/src/arm64/code-stubs-arm64.cc
@@ -4497,11 +4497,10 @@ void LoadICStub::GenerateForTrampoline(MacroAssembler* masm) { 
 }


-static void HandleArrayCases(MacroAssembler* masm, Register receiver,
-                             Register key, Register vector, Register slot,
-                             Register feedback, Register receiver_map,
-                             Register scratch1, Register scratch2,
-                             bool is_polymorphic, Label* miss) {
+static void HandleArrayCases(MacroAssembler* masm, Register feedback,
+                             Register receiver_map, Register scratch1,
+                             Register scratch2, bool is_polymorphic,
+                             Label* miss) {
   // feedback initially contains the feedback array
   Label next_loop, prepare_next;
   Label load_smi_map, compare_map;
@@ -4613,8 +4612,7 @@ void LoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   __ Bind(&try_array);
   __ Ldr(scratch1, FieldMemOperand(feedback, HeapObject::kMapOffset));
   __ JumpIfNotRoot(scratch1, Heap::kFixedArrayMapRootIndex, &not_array);
- HandleArrayCases(masm, receiver, name, vector, slot, feedback, receiver_map, 
-                   scratch1, x7, true, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, x7, true, &miss); 

   __ Bind(&not_array);
   __ JumpIfNotRoot(feedback, Heap::kmegamorphic_symbolRootIndex, &miss);
@@ -4671,8 +4669,7 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   // We have a polymorphic element handler.
   Label polymorphic, try_poly_name;
   __ Bind(&polymorphic);
- HandleArrayCases(masm, receiver, key, vector, slot, feedback, receiver_map, 
-                   scratch1, x7, true, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, x7, true, &miss); 

   __ Bind(&not_array);
   // Is it generic?
@@ -4691,8 +4688,7 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { __ Add(feedback, vector, Operand::UntagSmiAndScale(slot, kPointerSizeLog2)); 
   __ Ldr(feedback,
FieldMemOperand(feedback, FixedArray::kHeaderSize + kPointerSize)); - HandleArrayCases(masm, receiver, key, vector, slot, feedback, receiver_map, 
-                   scratch1, x7, false, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, x7, false, &miss); 

   __ Bind(&miss);
   KeyedLoadIC::GenerateMiss(masm);
Index: src/mips/code-stubs-mips.cc
diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc
index e20556c9808e3ace870b3086422d716068125f42..7df0ba2cd1a39981658632f4d34018c3bd5e6455 100644 
--- a/src/mips/code-stubs-mips.cc
+++ b/src/mips/code-stubs-mips.cc
@@ -4567,11 +4567,10 @@ void LoadICStub::GenerateForTrampoline(MacroAssembler* masm) { 
 }


-static void HandleArrayCases(MacroAssembler* masm, Register receiver,
-                             Register key, Register vector, Register slot,
-                             Register feedback, Register receiver_map,
-                             Register scratch1, Register scratch2,
-                             bool is_polymorphic, Label* miss) {
+static void HandleArrayCases(MacroAssembler* masm, Register feedback,
+                             Register receiver_map, Register scratch1,
+                             Register scratch2, bool is_polymorphic,
+                             Label* miss) {
   // feedback initially contains the feedback array
   Label next_loop, prepare_next;
   Label start_polymorphic;
@@ -4683,8 +4682,7 @@ void LoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   __ lw(scratch1, FieldMemOperand(feedback, HeapObject::kMapOffset));
   __ LoadRoot(at, Heap::kFixedArrayMapRootIndex);
   __ Branch(&not_array, ne, at, Operand(scratch1));
- HandleArrayCases(masm, receiver, name, vector, slot, feedback, receiver_map, 
-                   scratch1, t5, true, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, t5, true, &miss); 

   __ bind(&not_array);
   __ LoadRoot(at, Heap::kmegamorphic_symbolRootIndex);
@@ -4745,8 +4743,7 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 

   Label polymorphic, try_poly_name;
   __ bind(&polymorphic);
- HandleArrayCases(masm, receiver, key, vector, slot, feedback, receiver_map, 
-                   scratch1, t5, true, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, t5, true, &miss); 

   __ bind(&not_array);
   // Is it generic?
@@ -4765,8 +4762,7 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   __ Addu(feedback, vector, Operand(at));
   __ lw(feedback,
         FieldMemOperand(feedback, FixedArray::kHeaderSize + kPointerSize));
- HandleArrayCases(masm, receiver, key, vector, slot, feedback, receiver_map, 
-                   scratch1, t5, false, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, t5, false, &miss); 

   __ bind(&miss);
   KeyedLoadIC::GenerateMiss(masm);
Index: src/mips64/code-stubs-mips64.cc
diff --git a/src/mips64/code-stubs-mips64.cc b/src/mips64/code-stubs-mips64.cc index 49647a42069474f7b959f24c732cbe5198aad776..0fb3bd6c27d701a14f32cfa6471401b9c7706a3e 100644 
--- a/src/mips64/code-stubs-mips64.cc
+++ b/src/mips64/code-stubs-mips64.cc
@@ -4600,11 +4600,10 @@ void LoadICStub::GenerateForTrampoline(MacroAssembler* masm) { 
 }


-static void HandleArrayCases(MacroAssembler* masm, Register receiver,
-                             Register key, Register vector, Register slot,
-                             Register feedback, Register receiver_map,
-                             Register scratch1, Register scratch2,
-                             bool is_polymorphic, Label* miss) {
+static void HandleArrayCases(MacroAssembler* masm, Register feedback,
+                             Register receiver_map, Register scratch1,
+                             Register scratch2, bool is_polymorphic,
+                             Label* miss) {
   // feedback initially contains the feedback array
   Label next_loop, prepare_next;
   Label start_polymorphic;
@@ -4714,8 +4713,7 @@ void LoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   __ ld(scratch1, FieldMemOperand(feedback, HeapObject::kMapOffset));
   __ LoadRoot(at, Heap::kFixedArrayMapRootIndex);
   __ Branch(&not_array, ne, scratch1, Operand(at));
- HandleArrayCases(masm, receiver, name, vector, slot, feedback, receiver_map, 
-                   scratch1, a7, true, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, a7, true, &miss); 

   __ bind(&not_array);
   __ LoadRoot(at, Heap::kmegamorphic_symbolRootIndex);
@@ -4776,8 +4774,7 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 

   Label polymorphic, try_poly_name;
   __ bind(&polymorphic);
- HandleArrayCases(masm, receiver, key, vector, slot, feedback, receiver_map, 
-                   scratch1, a7, true, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, a7, true, &miss); 

   __ bind(&not_array);
   // Is it generic?
@@ -4796,8 +4793,7 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   __ Daddu(feedback, vector, Operand(feedback));
   __ ld(feedback,
         FieldMemOperand(feedback, FixedArray::kHeaderSize + kPointerSize));
- HandleArrayCases(masm, receiver, key, vector, slot, feedback, receiver_map, 
-                   scratch1, a7, false, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, a7, false, &miss); 

   __ bind(&miss);
   KeyedLoadIC::GenerateMiss(masm);
Index: src/x64/code-stubs-x64.cc
diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc
index d3b373e95520cacec13f90d44465592ba638a4a7..ed5b906b69215fb7cc0e1b96d9f21f8f84a5d869 100644 
--- a/src/x64/code-stubs-x64.cc
+++ b/src/x64/code-stubs-x64.cc
@@ -4311,12 +4311,10 @@ void KeyedLoadICTrampolineStub::Generate(MacroAssembler* masm) { 
 }


-static void HandleArrayCases(MacroAssembler* masm, Register receiver,
-                             Register key, Register vector, Register slot,
-                             Register feedback, Register receiver_map,
-                             Register scratch1, Register scratch2,
-                             Register scratch3, bool is_polymorphic,
-                             Label* miss) {
+static void HandleArrayCases(MacroAssembler* masm, Register feedback,
+                             Register receiver_map, Register scratch1,
+                             Register scratch2, Register scratch3,
+                             bool is_polymorphic, Label* miss) {
   // feedback initially contains the feedback array
   Label next_loop, prepare_next;
   Label start_polymorphic;
@@ -4418,8 +4416,8 @@ void LoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   __ bind(&try_array);
   __ CompareRoot(FieldOperand(feedback, 0), Heap::kFixedArrayMapRootIndex);
   __ j(not_equal, &not_array);
- HandleArrayCases(masm, receiver, name, vector, slot, feedback, receiver_map, 
-                   integer_slot, r11, r15, true, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, integer_slot, r11, r15, true, 
+                   &miss);

   __ bind(&not_array);
   __ CompareRoot(feedback, Heap::kmegamorphic_symbolRootIndex);
@@ -4477,8 +4475,8 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   // We have a polymorphic element handler.
   Label polymorphic, try_poly_name;
   __ bind(&polymorphic);
- HandleArrayCases(masm, receiver, key, vector, slot, feedback, receiver_map, 
-                   integer_slot, r11, r15, true, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, integer_slot, r11, r15, true, 
+                   &miss);

   __ bind(&not_array);
   // Is it generic?
@@ -4496,8 +4494,8 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   // at least one map/handler pair.
   __ movp(feedback, FieldOperand(vector, integer_slot, times_pointer_size,
                                  FixedArray::kHeaderSize + kPointerSize));
- HandleArrayCases(masm, receiver, key, vector, slot, feedback, receiver_map, 
-                   integer_slot, r11, r15, false, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, integer_slot, r11, r15, false, 
+                   &miss);

   __ bind(&miss);
   KeyedLoadIC::GenerateMiss(masm);


--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to