Looks much cleaner, thanks. Lgtm once comments are addressed.
https://codereview.chromium.org/1325983002/diff/40001/src/interpreter/bytecodes.cc
File src/interpreter/bytecodes.cc (right):
https://codereview.chromium.org/1325983002/diff/40001/src/interpreter/bytecodes.cc#newcode173
src/interpreter/bytecodes.cc:173:
nit extra newline
https://codereview.chromium.org/1325983002/diff/40001/src/interpreter/bytecodes.cc#newcode182
src/interpreter/bytecodes.cc:182: DCHECK_LE(index, parameter_count);
/s/DCHECK_LE/DCHECK_LT, no?
https://codereview.chromium.org/1325983002/diff/40001/src/interpreter/bytecodes.cc#newcode183
src/interpreter/bytecodes.cc:183: DCHECK_LE(parameter_count,
kMaxParameterIndex);
ditto
https://codereview.chromium.org/1325983002/diff/40001/test/unittests/interpreter/bytecodes-unittest.cc
File test/unittests/interpreter/bytecodes-unittest.cc (right):
https://codereview.chromium.org/1325983002/diff/40001/test/unittests/interpreter/bytecodes-unittest.cc#newcode27
test/unittests/interpreter/bytecodes-unittest.cc:27: std::vector<int>
parameter_counts{7, 13, 99};
Unfortunately I don't think this will work on Mac since it is relying on
c++11 library features. :(
Could you just do something like:
int parameter_counts[] = {7, 13, 99};
size_t count = sizeof parameter_counts / sizeof(int);
for (size_t p = 0; p < count; p++) {...
https://codereview.chromium.org/1325983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
