Thanks, that's going into the direction I had in mind.

For the first round:

Please move ArrayBufferTracker to its own .h/.cc files in src/heap/, add a
forward declaration in heap.h. Don't inline the object, but rather store a
pointer for an object that get's initialized properly.

Similar things happened for ObjectStats (which was also part of Heap) just
recently. See https://codereview.chromium.org/1326793002/ (especially for the
build related files).

As for the tests, I will think of something.

https://codereview.chromium.org/1324023007/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to