https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js
File tools/tickprocessor.js (right):
https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js#newcode461
tools/tickprocessor.js:461: var printAllTicks = this.printSummary_ ==
undefined ||
On 2015/09/03 08:37:08, Jakob wrote:
How about simply:
var printAllTicks = !this.onlySummary;
Done.
https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js#newcode517
tools/tickprocessor.js:517: }
On 2015/09/03 08:19:11, Michael Achenbach wrote:
nit: indentation of } and };
Done.
https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js#newcode896
tools/tickprocessor.js:896: '--print-summary': ['printSummary', true,
On 2015/09/03 08:37:08, Jakob wrote:
I'd call the flag --only-summary (and the corresponding variables
"onlySummary")
to make its effect more obvious.
Done.
https://codereview.chromium.org/1318933004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
