lgtm with nits:
https://codereview.chromium.org/1330483003/diff/200001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1330483003/diff/200001/src/bootstrapper.cc#newcode2341
src/bootstrapper.cc:2341: // Make sure that Function.prototype.call
appears to be compiled.
Please update comment.
https://codereview.chromium.org/1330483003/diff/200001/src/bootstrapper.cc#newcode2359
src/bootstrapper.cc:2359: // Make sure that Function.prototype.call
appears to be compiled.
Please update comment.
https://codereview.chromium.org/1330483003/diff/200001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/1330483003/diff/200001/src/builtins.cc#newcode1178
src/builtins.cc:1178: if (!obj->IsJSReceiver()) return false;
You call this only for JSArray objects. If you update the signature, you
can remove this check.
https://codereview.chromium.org/1330483003/diff/200001/src/builtins.cc#newcode1422
src/builtins.cc:1422: isolate->Throw(*isolate->factory()->NewRangeError(
Please add a comment here why do we throw here.
You can write
return isolate->Throw<JSArray>(*isolate->factory()->...);
https://codereview.chromium.org/1330483003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
