Reviewers: rmcilroy, Jarin, Michael Starzinger, mvstanton,
Message:
Created Revert of [builtins] Unify the various versions of [[Call]] with a
Call
builtin.
Description:
Revert of [builtins] Unify the various versions of [[Call]] with a Call
builtin.
(patchset #10 id:260001 of https://codereview.chromium.org/1311013008/ )
Reason for revert:
Breaks nosnap, needs investigation
Original issue's description:
[builtins] Unify the various versions of [[Call]] with a Call builtin.
The new Call and CallFunction builtins supersede the current
CallFunctionStub (and CallIC magic) and will be the single bottleneck
for all calling, including the currently special Function.prototype.call
and Function.prototype.apply builtins, which had handwritten (and
not fully compliant) versions of CallFunctionStub, and also the
CallIC(s), which where also slightly different.
This also reduces the overhead for API function calls, which is still
unnecessary high, but let's do that step-by-step.
This also fixes a bunch of cases where the implicit ToObject for
sloppy receivers was done in the wrong context (in the caller
context instead of the callee context), which basically meant
that we allowed cross context access to %ObjectPrototype%.
MIPS and MIPS64 ports contributed by akos.pa...@imgtec.com.
R=mstarzin...@chromium.org, ja...@chromium.org, mvstan...@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg
BUG=v8:4413
LOG=n
Committed: https://crrev.com/ef268a83be4dead004047c25b702319ea4be7277
Cr-Commit-Position: refs/heads/master@{#30627}
TBR=rmcil...@chromium.org,ja...@chromium.org,mstarzin...@chromium.org,mvstan...@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4413
Please review this at https://codereview.chromium.org/1328963004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1632, -1354 lines):
M src/arm/builtins-arm.cc
M src/arm/code-stubs-arm.cc
M src/arm/macro-assembler-arm.h
M src/arm/macro-assembler-arm.cc
M src/arm64/builtins-arm64.cc
M src/arm64/code-stubs-arm64.cc
M src/arm64/macro-assembler-arm64.h
M src/arm64/macro-assembler-arm64.cc
M src/bailout-reason.h
M src/builtins.h
M src/code-stubs.h
M src/contexts.h
M src/ia32/assembler-ia32.h
M src/ia32/assembler-ia32.cc
M src/ia32/builtins-ia32.cc
M src/ia32/code-stubs-ia32.cc
M src/ia32/macro-assembler-ia32.h
M src/ia32/macro-assembler-ia32.cc
M src/mips/builtins-mips.cc
M src/mips/code-stubs-mips.cc
M src/mips/macro-assembler-mips.h
M src/mips/macro-assembler-mips.cc
M src/mips64/builtins-mips64.cc
M src/mips64/code-stubs-mips64.cc
M src/mips64/macro-assembler-mips64.h
M src/mips64/macro-assembler-mips64.cc
M src/objects.h
M src/runtime.js
M src/runtime/runtime-function.cc
M src/x64/builtins-x64.cc
M src/x64/code-stubs-x64.cc
M src/x64/macro-assembler-x64.h
M src/x64/macro-assembler-x64.cc
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
