Sounds good to me. I'll have a patchset later tonight
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h#newcode2663
src/preparser.h:2663: goto shorthand_property;
On 2015/09/08 23:17:17, adamk wrote:
Can't you just do without the goto?
} else if ((is_get || is_set) &&
(in_class ||
(peek() != Token::ASSIGN &&
peek() != Token::COMMA &&
peek() != Token::RBRACE)) {
that'll fall through to the next else/if.
That's true. I think this is still a confusing hack which mixes up the
different productions, but it seems like a reasonable way to split off
from the refactoring. I'll do that.
https://codereview.chromium.org/1328083002/diff/80001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1328083002/diff/80001/src/preparser.h#newcode2641
src/preparser.h:2641: break;
On 2015/09/08 23:17:17, adamk wrote:
This break makes this whole approach not much easier to read (for me)
than the
old version.
It can work the other way, just makes the invention kind of bad
https://codereview.chromium.org/1328083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
