A few more minor comments. LGTM if you address those.
I've also updated the CL description to reflect the new approach.
https://codereview.chromium.org/1313493005/diff/60001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/1313493005/diff/60001/src/accessors.cc#newcode113
src/accessors.cc:113: DescriptorArray* descriptors =
map->instance_descriptors();
Before this is safe, you need to bail out for dictionary maps:
if (map->is_dictionary_map()) return false;
https://codereview.chromium.org/1313493005/diff/60001/src/accessors.cc#newcode120
src/accessors.cc:120: // Check if the property is overridden in the
prototype chain.
s/overridden/defined/
https://codereview.chromium.org/1313493005/diff/60001/src/accessors.cc#newcode122
src/accessors.cc:122: if (it.state() == LookupIterator::NOT_FOUND)
return false;
if (!it.IsFound()) return false;
https://codereview.chromium.org/1313493005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
