On 2015/09/09 at 23:35:56, info wrote:
https://codereview.chromium.org/1303093004/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1303093004/diff/1/src/api.cc#newcode3271
src/api.cc:3271: has_pending_exception =
On 2015/09/09 14:16:59, jochen wrote:
> can you pull the if() case in here instead of duplicating the returns?
>
> something like
>
> PREPARE_FOR...
> if (obj->isNumber())
> num = obj;
> else {
> has_pending = ...
That pessimizes the common case when the input is a SMI or double.
PREPARE_FOR_EXECUTION_PRIMITIVE mutates a couple of per-isolate data
structures
and is fairly heavy-weight.
yeah, that's true
lgtm then
https://codereview.chromium.org/1303093004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
