I don't have a particular beef with it.
Some minor comments.
https://codereview.chromium.org/1292283005/diff/20001/src/runtime/runtime-ptr.cc
File src/runtime/runtime-ptr.cc (right):
https://codereview.chromium.org/1292283005/diff/20001/src/runtime/runtime-ptr.cc#newcode39
src/runtime/runtime-ptr.cc:39: static Object*
fromAlignedPtr(aligned_ptr_t value) {
Camelcase function names should start with uppercase.
https://codereview.chromium.org/1292283005/diff/20001/src/runtime/runtime-ptr.cc#newcode111
src/runtime/runtime-ptr.cc:111: return (ptr == 0) ?
isolate->heap()->true_value()
return isolate->heap()->ToBoolean(ptr == nullptr);
https://codereview.chromium.org/1292283005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
