On 2015/10/01 15:30:13, Toon Verwaest wrote:
I still stand by my previous comments. I don't want access checks to be
exposed
by GetProperty.
How about something like "GetWellKnownSymbolHook()" instead? It doesn't
really
matter what it's called, but whatever it is needs to let the caller decide
what
happens when an access check fails.
My problem with the approach is that it would prevent ordinary [[Get]]s of
well-known symbols to throw, which is probably not what we want to do. They
still don't leak any information, but it's inconsistent with the rest of the
platform. So I would prefer to just give internal code the option to ignore
the
thing.
I'll send another patch set with your idea in mind anyways, though.
https://codereview.chromium.org/1230793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
