https://codereview.chromium.org/1309813007/diff/210001/src/expression-classifier.h
File src/expression-classifier.h (right):
https://codereview.chromium.org/1309813007/diff/210001/src/expression-classifier.h#newcode324
src/expression-classifier.h:324: if (b.location.beg_pos < 0 ||
b.location.beg_pos >= a.location.beg_pos) {
On 2015/10/28 19:11:41, adamk wrote:
Same here, I don't imagine pos < 0 is valid.
You'd be surprised, I ran into it a few times and added the DCHECK to
catch any more
https://codereview.chromium.org/1309813007/diff/210001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/1309813007/diff/210001/src/parser.h#newcode563
src/parser.h:563: struct MarkedAssignment {
On 2015/10/28 19:11:41, adamk wrote:
Looks like this snuck in from elsewhere? I don't see it used in this
patch. Same
with other marking infrastructure in this file.
Most of the changes in here aren't needed now, forgot about this one
https://codereview.chromium.org/1309813007/diff/210001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1309813007/diff/210001/src/preparser.h#newcode711
src/preparser.h:711: enum AssignmentFlags {
On 2015/10/28 19:11:41, adamk wrote:
This enum deserves a comment, along with a comment for each value. In
particular
I find the usage of kIsPatternElement somewhat counter-intuitive.
I'll add comments, but the general reasoning is this:
- Tracking whether eagerly desugaring AssigmentPatters might make it
harder or impossible to rewrite BindingPatterns.
- Tracking whether it's possibly ambiguous at all.
Even with the tracking, I'm fairly sure there are still corner cases"
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
