+100 I'm really glad this cleanup is happening. On Wed, Jul 13, 2016 at 5:08 AM, 'Yang Guo' via v8-dev < v8-dev@googlegroups.com> wrote:
> TL;DR: builtins.cc will be moved into its own folder and split up. > > Hi, > > we've been moving more and more builtins from JS to C++/Turbofan. A > consequence of this is that builtins.cc is dramatically growing in size, > and it will continue to do so. It is already becoming difficult to navigate. > > So in a move similarly to what has been done for runtime.cc, I'm planning > to > 1) move builtins.* into src/builtins/ > 2) move builtins-<platform>.cc into src/builtins/<platform>/ > 3) split up builtins implementations by the constructor they belong to, > i.e. Array.prototype methods are going to be put into builtins-array.cc, > etc. > 4) leave platform-dependent assembly builtins the way they are, since we > expect no significant number of newly implemented ones. > 5) move part of the bootstrapper that sets up objects into builtins. For > example, the code to set up Array and Array.prototype should be put into > builtins-array.cc, and called from Genesis::InitializeGlobal. The latter > currently has more than 1k LoC and ends with " // > NOLINT(readability/fn_size)". > > Step 3 and 5 can be done in incrementally and in parallel so I would > appreciate help there. I also filed an issue > <https://bugs.chromium.org/p/v8/issues/detail?id=5197>. > > Cheers, > > Yang > -- > > > > * • * > *Yang Guo** • **Google Germany GmbH* > * • *Erika-Mann-Str. 33 > * • *80636 Munich > > • yang...@google.com > > > Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle > > Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: > Hamburg > > Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, > leiten Sie diese bitte nicht weiter, informieren Sie den Absender und > löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is > confidential. If you are not the right addressee please do not forward it, > please inform the sender, and please erase this e-mail including any > attachments. Thanks. > > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
