I, for one, welcome our new code review overlords. That said, could the team put together a Known Issues doc with known problems and workarounds? It could save developers a lot of time.
For example, the fact that gerrit treats copied or split files as entirely new files <https://bugs.chromium.org/p/gerrit/issues/detail?id=6441> and provides no diff is something I'd expect a lot of developers to independently hit. Rather than assume they're doing something wrong and try a bunch of fixes like `git cl upload --similarity=5`, they could see immediately what (if anything) they can do. Similarly, is there any update on how long we can expect the site to lag when loading CLs, showing diffs, editing descriptions <https://bugs.chromium.org/p/gerrit/issues/detail?id=6406#c2> and commenting <https://bugs.chromium.org/p/gerrit/issues/detail?id=6733>? Again, I point these out as examples of known issues, not something that blocks us from using Gerrit but something that'd be nice to know others are experiencing. Some sort of "service status" dashboard could be useful for us. On Thu, Jul 20, 2017 at 2:22 PM Aaron Gable <[email protected]> wrote: > *Primary Eng* > [email protected] > > *Summary* > One week from today, on Thursday, July 27, codereview.chromium.org will > begin refusing uploads of new changes to chromium/src.git and v8/v8.git. By > the end of Q3 (exact date TBD), Rietveld will become fully read-only, > including for existing changes. > > *Motivation* > Now that both Chromium and V8 have been using Gerrit by default for a few > weeks, the continued presence of Rietveld as a code review tool is both a > drain on the contributors who have to context switch between the two > systems, and a maintenance burden on the infrastructure team. As a step > towards making Rietveld fully ready-only, we are disabling uploads of new > changes to individual projects so that large portions of the contributor > population don't have to live in this two-system world for too long. > > *Interoperability Risk* > If you have changes which are already uploaded to Rietveld and are > undergoing review, you'll be able to continue working with those changes as > normal. However, if you are asked to split a change, you won't be able to > upload the new one to Rietveld. Depending on how comfortable you and your > reviewers are switching back and forth between the systems, you may want to > migrate your existing changes to Gerrit using "git cl issue 0 && git cl > upload". > > *Suggestions from Developers* > As always, if you have questions about Gerrit, consult the faq > <https://polygerrit.appspot.com>. If you want to file a bug about the > Gerrit web UI, use the "Send feedback > <https://bugs.chromium.org/p/gerrit/issues/entry?template=PolyGerrit%20Issue>" > link in the site footer. If you want to file a bug about git-cl, or about > some piece of automation which starts failing, use this template > <https://bugs.chromium.org/p/chromium/issues/entry?template=Build%20Infrastructure&summary=[Please%20enter%20summary]&components=Infra%3ESDK&labels=OS-Linux,Type-Bug&description=What%20command%20line%20did%20you%20execute?%0D%0DWhat%20was%20the%20output?%0D%0DWhat%20did%20you%20expect%20instead?> > . > > *Usage Information* > In the last week, 95% of all commits to src.git and 99% of all commits to > v8.git were reviewed on Gerrit. > > *[image: commits (3).png][image: commits (4).png]Launch Tracking Bug* > Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=685321 > V8: https://bugs.chromium.org/p/chromium/issues/detail?id=685318 > > Thanks, > Aaron > > -- > -- > Chromium Developers mailing list: [email protected] > View archives, change email options, or unsubscribe: > http://groups.google.com/a/chromium.org/group/chromium-dev > --- > You received this message because you are subscribed to the Google Groups > "Chromium-dev" group. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAH58R2cTGjxdXhj_rS90dNFB4CNThyvkuwusQ9_P4OiGVEMhkg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAH58R2cTGjxdXhj_rS90dNFB4CNThyvkuwusQ9_P4OiGVEMhkg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
