LGTM
http://codereview.chromium.org/650127/diff/1001/1002 File src/bootstrapper.cc (right): http://codereview.chromium.org/650127/diff/1001/1002#newcode1054 src/bootstrapper.cc:1054: // Builtin function for BlindReference -- a JSValue-based object, Could we find a better name that BlindReference? How about OpaqueReference, HiddenReference or HiddenObjectReference? http://codereview.chromium.org/650127/diff/1001/1004 File src/liveedit.cc (right): http://codereview.chromium.org/650127/diff/1001/1004#newcode132 src/liveedit.cc:132: int GetSmiField(int field_position) { This functions does not return a smi, so ither it should have a different name or return a Smi. Maybe GetSmiValueField, maybe remove the Field postfix for all these functions. http://codereview.chromium.org/650127/diff/1001/1004#newcode140 src/liveedit.cc:140: This comment mentions SharedFunctionInfo. Have the comments for the two classes been mixed up? http://codereview.chromium.org/650127/diff/1001/1004#newcode151 src/liveedit.cc:151: SetField(kFunctionNameOffset_, name); Why is the handle scope not at the top? http://codereview.chromium.org/650127/diff/1001/1004#newcode199 src/liveedit.cc:199: Are the name, start_position and end_poition not available in the shared function info? http://codereview.chromium.org/650127/diff/1001/1004#newcode204 src/liveedit.cc:204: SetField(kSharedInfoOffset_, info_holder); Why is the handle scope not at the top? http://codereview.chromium.org/650127 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
