Some additional info: the code->kind() is equal to 0 which is defined as an OPTIMIZED_FUNCTION.
On Friday, July 13, 2018 at 2:44:01 PM UTC-4, Jakob Kummerow wrote: > > -chromium-dev +v8-dev > > On Fri, Jul 13, 2018 at 8:10 AM Demetrios Tsillas <jtsi...@gmail.com > <javascript:>> wrote: > >> I have some code I use to gather statistical information out of v8 by >> capturing stack traces at a few defined points. >> >> This code worked fine with 66 but I have re-based to 68 and now see aw >> snap crashes with missing de-optimization information. >> >> I saw the work from >> https://groups.google.com/forum/#!msg/v8-reviews/XYX3q0SF580/bpNuPb4NBgAJ >> but I have this fix already. >> >> The failure is on the topmost frame which I expect would be for the >> internal call to: >> >> chrome_child.dll!v8::internal::Runtime_DateCurrentTime(int >> args_length, v8::internal::Object * * args_object, v8::internal::Isolate * >> isolate) Line 24 C++ >> >> I see where the call to Summarize checks for Code::BUILTIN. Is there a >> case where we might not have that kind() . >> >> I see the TODO: >> >> // Delegate to JS frame in absence of turbofan deoptimization. >> // TODO(turbofan): Revisit once we support deoptimization across the >> board. >> >> Is it possible to return JavaScriptFrame::Summarize(frames) if no >> deoptimization is found? >> >> thanks!!! >> -Jim. >> >> -- >> -- >> Chromium Developers mailing list: chromi...@chromium.org <javascript:> >> View archives, change email options, or unsubscribe: >> http://groups.google.com/a/chromium.org/group/chromium-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "Chromium-dev" group. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/2c1528e8-8523-4a95-9bc8-c6dd2d50ceaa%40chromium.org >> >> <https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/2c1528e8-8523-4a95-9bc8-c6dd2d50ceaa%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
