You can send them for review at the same time. I'd suggest to put notes pointing at each other into the respective descriptions (e.g. "This depends on the following build.git change: <url>" and "This prepares the following V8-side change: <url>"). Of course committing the patches, assuming successful review, will have to happen in the order you described so that no build breaks (even temporarily).
On Mon, Sep 24, 2018 at 9:37 AM <lilo...@gmail.com> wrote: > Thanks for the notice. For contribution of this type of change, I meant do > I need to send patch to build.git for review at first, and only send patch > to V8 after the change for build.git is accepted and reaches V8 repo, > because the latter depends on the former build script change? > > On Friday, September 21, 2018 at 3:24:29 PM UTC-7, Jakob Kummerow wrote: >> >> In short: create a Chromium checkout, create a patch, get it reviewed and >> landed. Details: https://www.chromium.org/developers/contributing-code >> >> Please be aware that there is a chance of pushback -- depending on what >> you're changing and how, people might not like it. I can't estimate how >> likely that is in this case. >> >>> >>> -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
