LGTM
http://codereview.chromium.org/652118/diff/1/13 File src/arm/macro-assembler-arm.h (right): http://codereview.chromium.org/652118/diff/1/13#newcode335 src/arm/macro-assembler-arm.h:335: // Call a runtime routine. The comment "Eventually this should be used for all C calls" seems to be obsolete. http://codereview.chromium.org/652118/diff/1/13#newcode346 src/arm/macro-assembler-arm.h:346: // Tail call of a C routine (jump). I think we should keep this as runtime. When referring to runtime functions it is not only functions in runtime.cc, but both C and assembler function we call into from generated code. these functions don't expect normal C calling convention. For the other architectures as well. http://codereview.chromium.org/652118/diff/1/13#newcode358 src/arm/macro-assembler-arm.h:358: // Jump to a runtime routine. I think this should be renamed to JumpToExternalReference for consistency. For the other architectures as well. http://codereview.chromium.org/652118 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
