We don't check this on dry-run, afaik, so that dry runs don't fail during the review process (and reviewers can easily see if tests pass).
On Mon, Oct 22, 2018 at 11:39 AM Sergiy Byelozyorov <serg...@chromium.org> wrote: > The presubmit has also failed since an owner of the V8 root directory > needs to LGTM your CL. OTH, I am surprised that we do this check on dry-run. > > With regards to being in the AUTHORS file, adding an alternative email may > not be sufficient since I can see that the presubmit code simply checks > author_email field > <https://cs.chromium.org/chromium/tools/depot_tools/presubmit_canned_checks.py?l=92&rcl=98f1e59b41c6c580cd168ac4456bf27d78c12a95>, > which is probably the default email address. +infra-...@chromium.org > <infra-...@chromium.org>, can you please advice if Isiah needs to > register a new account on Gerrit or if their existing account can be > updated somehow to use the new address as a primary one? > > On Sun, Oct 21, 2018 at 3:27 PM 'Mathias Bynens' via v8-dev < > v8-dev@googlegroups.com> wrote: > >> [image: image.png] >> >> On Sat, Oct 20, 2018 at 9:45 PM Isiah Meadows <impinb...@gmail.com> >> wrote: >> >>> It *should* be the same account. I added it as an alternate email. >>> >>> On Saturday, October 20, 2018 at 1:09:57 AM UTC-4, Jakob Kummerow wrote: >>>> >>>> As you can see on the CL, it fails the presubmit check, because it is >>>> has been created by an account that's not listed in the AUTHORS file, so it >>>> can't be landed. You'll have to re-upload it from the account that you're >>>> adding to the AUTHORS file. >>>> >>>> On Fri, Oct 19, 2018 at 7:50 PM Isiah Meadows <impi...@gmail.com> >>>> wrote: >>>> >>>>> I made a quick, small CL about a month ago to change my email listed >>>>> in the AUTHORS file, and nobody has looked at it yet. Did I miss >>>>> something, >>>>> or was it just forgotten? >>>>> >>>>> https://chromium-review.googlesource.com/c/v8/v8/+/1246801 >>>>> >>>>> -- >>>>> -- >>>>> v8-dev mailing list >>>>> v8-...@googlegroups.com >>>>> http://groups.google.com/group/v8-dev >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "v8-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to v8-dev+un...@googlegroups.com. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> -- >>> -- >>> v8-dev mailing list >>> v8-dev@googlegroups.com >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to v8-dev+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -- >> v8-dev mailing list >> v8-dev@googlegroups.com >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to v8-dev+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- > Sergiy Byelozyorov | Software Engineer | serg...@google.com > > Google Germany GmbH > Erika-Mann-Strasse 33 > 80636 München > > AG Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg | Geschäftsführer: > Paul Manicle, Halimah DeLaine Prado > > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
