On 2010/02/24 22:35:39, Søren Gjesse wrote:
LGTM
http://codereview.chromium.org/657080/diff/1/5
File src/ia32/macro-assembler-ia32.cc (right):
http://codereview.chromium.org/657080/diff/1/5#newcode1626
src/ia32/macro-assembler-ia32.cc:1626: // TODO(lrn): Since we no longer
use
the
system stack arbitrarily (but we do
Please remove this comment. I don't think it makes sense any more.
http://codereview.chromium.org/657080/diff/1/5#newcode1645
src/ia32/macro-assembler-ia32.cc:1645: int num_arguments) {
Please make a comment here that trashing eax is ok as it will be the
return
value.
I just looked at CodeGenerator::GenerateRandomPositiveSmi, and we should use
your new macro assembler functions there as well.
http://codereview.chromium.org/657080
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
