Hah, thanks. Turns out I accidentally created the CL using my Google
account instead of the personal one I used in the past. So my personal
account wasn't allowed to ask for the review, unsurprisingly... Sorry for
the noise. :)

On Tue, Jan 28, 2020 at 8:34 AM 'Santiago Aboy Solanes' via v8-dev <
[email protected]> wrote:

> There's supposed to be a "send", and a "start review" button. Click "start
> review".
>
> On Tue, Jan 28, 2020 at 4:30 PM 'Jan Krems' via v8-dev <
> [email protected]> wrote:
>
>> Hello everyone,
>>
>> After a longer time I tried submitting another patch to V8, following the 
>> guide
>> on v8.dev <https://v8.dev/docs/contribute> and the linked Chromium guide
>> to request a review
>> <https://chromium.googlesource.com/chromium/src/+/master/docs/contributing.md#Code-review>.
>> But after selecting reviewers and clicking "Send", the CL is still in "Work
>> in Progress", warning that reviewers won't be notified. Is there a step I
>> missed?
>>
>> The CL in question is
>> https://chromium-review.googlesource.com/c/v8/v8/+/1995312.
>>
>> Cheers,
>> Jan
>>
>> --
>> --
>> v8-dev mailing list
>> [email protected]
>> http://groups.google.com/group/v8-dev
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "v8-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [email protected].
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/v8-dev/f3302419-5fe9-4c63-9ef7-bdef82760918%40googlegroups.com
>> <https://groups.google.com/d/msgid/v8-dev/f3302419-5fe9-4c63-9ef7-bdef82760918%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>>
> --
> --
> v8-dev mailing list
> [email protected]
> http://groups.google.com/group/v8-dev
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/v8-dev/CAFKEYJgoWQzcPYus2L9xF_qQdwJYWSo345F2n7DtDeM%2B-2fQ9Q%40mail.gmail.com
> <https://groups.google.com/d/msgid/v8-dev/CAFKEYJgoWQzcPYus2L9xF_qQdwJYWSo345F2n7DtDeM%2B-2fQ9Q%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
>


-- 

Jan Krems |  Software Engineer |  [email protected] |  6504228673

-- 
-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/v8-dev/CADgPXdafvsf45wh3rQ%3D7KJo5WtgpJNi_pS%2BUvSM7ZN7i29G%2BZQ%40mail.gmail.com.

Reply via email to