Or, if the question "what method should i use instead" refers to how to fix the out of date comment, I don't think that part is needed any more as the new method names are self-explanatory.
On Wed, Feb 10, 2021 at 1:07 PM 'Ulan Degenbaev' via v8-dev < v8-dev@googlegroups.com> wrote: > > what method should i use instead? > set_max_old_generation_size_in_bytes() instead of set_max_old_space_size() > set_max_young_generation_size_in_bytes() instead of > set_max_semi_space_size() > set_code_range_size_in_bytes() instead of set_code_range_size() > There was no set_max_executable_size() > > Please keep in mind that you need to convert the arguments from MB to > bytes. > > Cheers, > Ulan. > > > On Wed, Feb 10, 2021 at 1:03 PM Marja Hölttä <ma...@chromium.org> wrote: > >> Yes, looks like the comment is out of date and the methods have been >> removed by this commit: >> https://chromium-review.googlesource.com/c/v8/v8/+/2539919 >> >> We don't develop in Github - for instructions on how to contribute, >> please see here: https://v8.dev/docs/contribute >> >> On Wed, Feb 10, 2021 at 12:32 PM saber mesgari <saber.mesg...@gmail.com> >> wrote: >> >>> Hi, I thinks the methods: >>> set_max_old_space_size >>> set_max_semi_space_size >>> set_max_executable_size >>> set_code_range_size >>> are deprecated. But still exist in v8.h file: >>> https://github.com/v8/v8/blob/master/include/v8.h#L7254 >>> can i send a PR to fix this? >>> what method should i use instead? >>> >>> -- >>> -- >>> v8-dev mailing list >>> v8-dev@googlegroups.com >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to v8-dev+unsubscr...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/v8-dev/6beb489f-7187-4d73-ba54-69a59d6b1daen%40googlegroups.com >>> <https://groups.google.com/d/msgid/v8-dev/6beb489f-7187-4d73-ba54-69a59d6b1daen%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> >> >> -- >> >> >> Google Germany GmbH >> >> Erika-Mann-Straße 33 >> >> 80636 München >> >> Geschäftsführer: Paul Manicle, Halimah DeLaine Prado >> >> Registergericht und -nummer: Hamburg, HRB 86891 >> >> Sitz der Gesellschaft: Hamburg >> >> Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten >> haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, >> löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, >> dass die E-Mail an die falsche Person gesendet wurde. >> >> >> >> This e-mail is confidential. If you received this communication by >> mistake, please don't forward it to anyone else, please erase all copies >> and attachments, and please let me know that it has gone to the wrong >> person. >> >> -- >> -- >> v8-dev mailing list >> v8-dev@googlegroups.com >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to v8-dev+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/v8-dev/CAED6dUCnw_40uZag6BqSu9Op_vYoYwkqnuZ752be0Ry4fr2BpA%40mail.gmail.com >> <https://groups.google.com/d/msgid/v8-dev/CAED6dUCnw_40uZag6BqSu9Op_vYoYwkqnuZ752be0Ry4fr2BpA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/CABNJt2%2BL9eSdwXqXHETtpKh6QORsuaX4yWqPfKx0bd%3D6OhzhiQ%40mail.gmail.com > <https://groups.google.com/d/msgid/v8-dev/CABNJt2%2BL9eSdwXqXHETtpKh6QORsuaX4yWqPfKx0bd%3D6OhzhiQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- Google Germany GmbH Erika-Mann-Straße 33 80636 München Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAED6dUC3jb8y6415N2Dr7xA%3Djsd8LNurvO-KN5QJTMVVLVqPTg%40mail.gmail.com.
