On Tue, Feb 23, 2021 at 8:39 PM Tony Godspeed <tonygodspee...@gmail.com> wrote:
> OptimizedAllocate can be called in CodeStubAssembler > <https://source.chromium.org/chromium/chromium/src/+/master:v8/src/codegen/code-stub-assembler.h;drc=6b915141921db226707d6b4aa21144890b682cfe;bpv=1;bpt=1;l=304> > ::Allocate > <https://source.chromium.org/chromium/chromium/src/+/master:v8/src/codegen/code-stub-assembler.cc;drc=6b915141921db226707d6b4aa21144890b682cfe;bpv=1;bpt=1;l=1236?gsn=Allocate&gs=kythe%3A%2F%2Fchromium.googlesource.com%2Fchromium%2Fsrc%3Flang%3Dc%252B%252B%3Fpath%3Dsrc%2Fv8%2Fsrc%2Fcodegen%2Fcode-stub-assembler.cc%23-5YDa5Hynkz3OCbhBpPaE76vWoGAPwBuJdHC-O5ImZE> > > https://source.chromium.org/chromium/chromium/src/+/master:v8/src/codegen/code-stub-assembler.cc;l=1254;drc=6b915141921db226707d6b4aa21144890b682cfe;bpv=1;bpt=1 > > How does this work when an unoptimized code paths call this function? It > looks like OptimizedAllocate adds a node to the graph which shouldn't do > anything when called from un-optimized code. By 'unoptimized code', do you mean CSA/tq? The MemoryOptimizationPhase runs on the CSA pipeline <https://source.chromium.org/chromium/chromium/src/+/master:v8/src/compiler/pipeline.cc;l=2929;drc=f23930e3110d8633041e7a86bb3d825cf3f148d5> as well, that's where AllocateRaw nodes are lowered for builtins. > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/7e5d174e-d9e8-47a9-b319-b6e2ce59bd76n%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/7e5d174e-d9e8-47a9-b319-b6e2ce59bd76n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAH3p7oMTYuTPb31QjKw9zNKxKFQv3VRnVYtnPKqsH6WdZ8SQRw%40mail.gmail.com.
