+Lutz Vahl <v...@google.com> who worked on the port-committer status. What is the current process for making brice.do...@futurewei.com a port committer?
Port committer ~= committer status to give CR+1, with the agreement to only change port files, e.g. *riscv*.*. On Thu, Apr 8, 2021 at 10:00 AM Yahan Lu <ya...@iscas.ac.cn> wrote: > Thanks jgruber > Are you mean that Brice is not a committer so can't code review? > 在2021年4月6日星期二 UTC+8 下午5:19:55<jgr...@google.com> 写道: > >> +Michael Achenbach AFAIK you need committer status to set code review >> bits. >> >> On Tue, Apr 6, 2021 at 11:17 AM Yahan Lu <ya...@iscas.ac.cn> wrote: >> >>> Very grateful if someone helps me grateful. >>> >>> Best wishes. >>> LuYahan >>> >>> 在2021年4月6日星期二 UTC+8 下午5:08:36<Yahan Lu> 写道: >>> >>>> Brice(brice...@futurewei.com) had added into RISCV_OWNERS file, but >>>> Brice have no vote right to code review riscv64 files. For example : >>>> https://chromium-review.googlesource.com/c/v8/v8/+/2763963 >>>> >>>> Can anyone give him code-riview right on riscv64 file? >>>> >>>> >>>> -- >>> -- >>> v8-dev mailing list >>> v8-...@googlegroups.com >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to v8-dev+un...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/v8-dev/b093d490-f017-4ad8-852a-1b53acd42f5cn%40googlegroups.com >>> <https://groups.google.com/d/msgid/v8-dev/b093d490-f017-4ad8-852a-1b53acd42f5cn%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/9e00bc6e-5c27-4243-86f1-40c6bfa7f75cn%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/9e00bc6e-5c27-4243-86f1-40c6bfa7f75cn%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAEp%2Bsk2JiiQAod9CaB080WF4v%3DDFNeMHn%2BFAZH-xu1vTjL14%3Dw%40mail.gmail.com.