Background:
- We currently have a mix of passing builtin ids as int or Builtins::Name
enums in various places.
- Additionally we sometimes pass code-handles
<https://source.chromium.org/chromium/chromium/src/+/main:v8/src/codegen/x64/macro-assembler-x64.cc;l=1659;drc=a39ebe6edcd18a1917ffebedc58828401050b16a;bpv=1;bpt=1>
to builtins in the macro assembler

Goal:
Clean up the existing code to only use the new Builtin enum class and avoid
creating handles to builtins altogether in the macro-assembler.

Code Impact: largish
- Mechanical renaming is required in various codegen related places

Programmer Impact: minimal
- Just use Builtin:kXXX instead of Builtins:kXXX
- All static methods will keep on living in Bultin*s* and not in Builtin

Cheers,
Camillo

Camillo Bruni |  Software Engineer, V8 |  Google Germany GmbH |  Erika-Mann
Str. 33, 80636 München

Registergericht und -nummer: Hamburg, HRB 86891 | Sitz der Gesellschaft:
Hamburg | Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Diese E-Mail ist vertraulich. Falls Sie diese fälschlicherweise erhalten
haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
dass die E-Mail an die falsche Person gesendet wurde.  This e-mail is
confidential. If you received this communication by mistake, please don't
forward it to anyone else, please erase all copies and attachments, and
please let me know that it has gone to the wrong person.

-- 
-- 
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/v8-dev/CAOeS1i-z7NjiHzOm-6%3D%3DWTOcWJcS1gumAuRkHEyZA3-Tr%3DrGZw%40mail.gmail.com.

Reply via email to